Use globalThis instead of window (S7764)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-10 00:30:33 +08:00
parent ebd198e28d
commit 5d143d4cc3
8 changed files with 21 additions and 21 deletions

View File

@@ -90,7 +90,7 @@ apiClient.interceptors.response.use(
deleteCookie("luciaToken");
deleteCookie("luciaRefreshToken");
deleteCookie("isLuciaLoggedIn");
window.location.href = "/login";
globalThis.location.href = "/login";
return Promise.reject(refreshError);
}
},

View File

@@ -34,6 +34,6 @@ export const printObject = (obj, indent = 0) => {
*/
export const getRandomInt = (max) => {
const array = new Uint32Array(1);
window.crypto.getRandomValues(array);
globalThis.crypto.getRandomValues(array);
return Math.floor((array[0] / (0xffffffff + 1)) * (max + 1));
};

View File

@@ -409,7 +409,7 @@ function handleClick(tagId) {
isActive.value = tagId;
if (isSafeTagId(tagId)) {
window.location.href = tagId;
globalThis.location.href = tagId;
} else {
console.warn("Unsafe tagId: ", tagId);
}

View File

@@ -392,7 +392,7 @@ function handleClick(tagId) {
isActive.value = tagId;
if (isSafeTagId(tagId)) {
window.location.href = tagId;
globalThis.location.href = tagId;
} else {
console.warn("Unsafe tagId: ", tagId);
}

View File

@@ -928,7 +928,7 @@ const handleWindowClick = (e) => {
onMounted(async () => {
isLoading.value = true;
await store.fetchAllFiles();
window.addEventListener("click", handleWindowClick);
globalThis.addEventListener("click", handleWindowClick);
// Add the .scrollbar class to the DataTable tbody
const tbodyElement = document.querySelector(".p-datatable-tbody");
tbodyElement?.classList.add("scrollbar");
@@ -936,7 +936,7 @@ onMounted(async () => {
});
onBeforeUnmount(() => {
window.removeEventListener("click", handleWindowClick);
globalThis.removeEventListener("click", handleWindowClick);
});
</script>
<style scoped>

View File

@@ -329,7 +329,7 @@ function getTextWidth(text, e) {
const hiddenSpan = document.createElement("span");
hiddenSpan.textContent = processedText;
hiddenSpan.style.font = window.getComputedStyle(e).font;
hiddenSpan.style.font = globalThis.getComputedStyle(e).font;
hiddenSpan.style.visibility = "hidden";
document.body.appendChild(hiddenSpan);
const width = hiddenSpan.getBoundingClientRect().width;

View File

@@ -235,13 +235,13 @@ describe("filesStore", () => {
it("downloads CSV for a log", async () => {
mockGet.mockResolvedValue({ data: "col1,col2\na,b" });
window.URL.createObjectURL = vi.fn().mockReturnValue("blob:test");
window.URL.revokeObjectURL = vi.fn();
globalThis.URL.createObjectURL = vi.fn().mockReturnValue("blob:test");
globalThis.URL.revokeObjectURL = vi.fn();
await store.downloadFileCSV("log", 3, "my-file");
expect(mockGet).toHaveBeenCalledWith("/api/logs/3/csv");
expect(window.URL.revokeObjectURL).toHaveBeenCalledWith("blob:test");
expect(globalThis.URL.revokeObjectURL).toHaveBeenCalledWith("blob:test");
});
it("returns early for unsupported type", async () => {

View File

@@ -96,15 +96,15 @@ describe("loginStore", () => {
// btoa('/dashboard') = 'L2Rhc2hib2FyZA=='
store.rememberedReturnToUrl = btoa("/dashboard");
// Mock window.location.href setter
const originalLocation = window.location;
delete window.location;
window.location = { href: "" };
// Mock globalThis.location.href setter
const originalLocation = globalThis.location;
delete globalThis.location;
globalThis.location = { href: "" };
await store.signIn();
expect(window.location.href).toBe("/dashboard");
window.location = originalLocation;
expect(globalThis.location.href).toBe("/dashboard");
globalThis.location = originalLocation;
});
it("does not redirect to external URL (open redirect prevention)", async () => {
@@ -117,17 +117,17 @@ describe("loginStore", () => {
// Attacker crafts a return-to URL pointing to an external site
store.rememberedReturnToUrl = btoa("https://evil.example.com/steal");
const originalLocation = window.location;
delete window.location;
window.location = { href: "" };
const originalLocation = globalThis.location;
delete globalThis.location;
globalThis.location = { href: "" };
await store.signIn();
// Should NOT redirect to the external URL
expect(window.location.href).not.toBe("https://evil.example.com/steal");
expect(globalThis.location.href).not.toBe("https://evil.example.com/steal");
// Should fall back to /files
expect(store.$router.push).toHaveBeenCalledWith("/files");
window.location = originalLocation;
globalThis.location = originalLocation;
});
it("falls back to /files when return-to is not valid base64", async () => {