imacat/mia-accounting
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 41 Wiki Activity

Replaced the traditional function expressions with ES6 arrow function expressions in the JavaScript for the account selector.

Browse Source
This commit is contained in:
依瑪貓 2023-03-04 08:02:02 +08:00
parent b3777cffbf
commit e118422441
1 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/accounting/static/js/account-selector.js
View File

@ -22,7 +22,7 @@
*/ */
// Initializes the page JavaScript. // Initializes the page JavaScript.
document.addEventListener("DOMContentLoaded", function () { document.addEventListener("DOMContentLoaded", () => {
AccountSelector.initialize(); AccountSelector.initialize();
}); });
@ -65,13 +65,12 @@ class AccountSelector {
const more = document.getElementById(this.#prefix + "-more"); const more = document.getElementById(this.#prefix + "-more");
const btnClear = document.getElementById(this.#prefix + "-btn-clear"); const btnClear = document.getElementById(this.#prefix + "-btn-clear");
const options = Array.from(document.getElementsByClassName(this.#prefix + "-option")); const options = Array.from(document.getElementsByClassName(this.#prefix + "-option"));
const selector1 = this more.onclick = () => {
more.onclick = function () {
more.classList.add("d-none"); more.classList.add("d-none");
selector1.#filterAccountOptions(); this.#filterAccountOptions();
}; };
this.#initializeAccountQuery(); this.#initializeAccountQuery();
btnClear.onclick = function () { btnClear.onclick = () => {
formAccountControl.classList.remove("accounting-not-empty"); formAccountControl.classList.remove("accounting-not-empty");
formAccount.innerText = ""; formAccount.innerText = "";
formAccount.dataset.code = ""; formAccount.dataset.code = "";
@ -79,7 +78,7 @@ class AccountSelector {
validateJournalEntryAccount(); validateJournalEntryAccount();
}; };
for (const option of options) { for (const option of options) {
option.onclick = function () { option.onclick = () => {
formAccountControl.classList.add("accounting-not-empty"); formAccountControl.classList.add("accounting-not-empty");
formAccount.innerText = option.dataset.content; formAccount.innerText = option.dataset.content;
formAccount.dataset.code = option.dataset.code; formAccount.dataset.code = option.dataset.code;
@ -95,9 +94,8 @@ class AccountSelector {
*/ */
#initializeAccountQuery() { #initializeAccountQuery() {
const query = document.getElementById(this.#prefix + "-query"); const query = document.getElementById(this.#prefix + "-query");
const selector = this; query.addEventListener("input", () => {
query.addEventListener("input", function () { this.#filterAccountOptions();
selector.#filterAccountOptions();
}); });
} }
@ -159,7 +157,7 @@ class AccountSelector {
* @return {boolean} true if the account option should show, or false otherwise * @return {boolean} true if the account option should show, or false otherwise
*/ */
#shouldAccountOptionShow(option, more, inUse, query) { #shouldAccountOptionShow(option, more, inUse, query) {
const isQueryMatched = function () { const isQueryMatched = () => {
if (query.value === "") { if (query.value === "") {
return true; return true;
} }
@ -171,7 +169,7 @@ class AccountSelector {
} }
return false; return false;
}; };
const isMoreMatched = function () { const isMoreMatched = () => {
if (more.classList.contains("d-none")) { if (more.classList.contains("d-none")) {
return true; return true;
} }
@ -237,10 +235,7 @@ class AccountSelector {
static #initializeTransactionForm() { static #initializeTransactionForm() {
const entryForm = document.getElementById("accounting-entry-form"); const entryForm = document.getElementById("accounting-entry-form");
const formAccountControl = document.getElementById("accounting-entry-form-account-control"); const formAccountControl = document.getElementById("accounting-entry-form-account-control");
const selectors = this.#selectors; formAccountControl.onclick = () => this.#selectors[entryForm.dataset.entryType].initShow();
formAccountControl.onclick = function () {
selectors[entryForm.dataset.entryType].initShow();
};
} }
/** /**
* Initializes the account selector for the journal entry form. * Initializes the account selector for the journal entry form.