Replaced the "transaction" property with the "url" property in the ReportEntry model of ledger, so that the report entry does not need to keep the transaction object.

This commit is contained in:
依瑪貓 2023-03-09 08:59:48 +08:00
parent 4ce577d7d8
commit d19d23fe37
2 changed files with 6 additions and 5 deletions

View File

@ -46,8 +46,6 @@ class ReportEntry:
:param entry: The journal entry. :param entry: The journal entry.
""" """
self.transaction: Transaction | None = None
"""The transaction."""
self.is_brought_forward: bool = False self.is_brought_forward: bool = False
"""Whether this is the brought-forward entry.""" """Whether this is the brought-forward entry."""
self.is_total: bool = False self.is_total: bool = False
@ -64,13 +62,16 @@ class ReportEntry:
"""The balance.""" """The balance."""
self.note: str | None = None self.note: str | None = None
"""The note.""" """The note."""
self.url: str | None = None
"""The URL to the journal entry."""
if entry is not None: if entry is not None:
self.transaction = entry.transaction
self.date = entry.transaction.date self.date = entry.transaction.date
self.summary = entry.summary self.summary = entry.summary
self.debit = entry.amount if entry.is_debit else None self.debit = entry.amount if entry.is_debit else None
self.credit = None if entry.is_debit else entry.amount self.credit = None if entry.is_debit else entry.amount
self.note = entry.transaction.note self.note = entry.transaction.note
self.url = url_for("accounting.transaction.detail",
txn=entry.transaction)
class EntryCollector: class EntryCollector:

View File

@ -79,7 +79,7 @@ First written: 2023/3/5
{% endwith %} {% endwith %}
{% endif %} {% endif %}
{% for entry in report.entries %} {% for entry in report.entries %}
<a class="accounting-report-table-row" href="{{ url_for("accounting.transaction.detail", txn=entry.transaction)|accounting_append_next }}"> <a class="accounting-report-table-row" href="{{ entry.url|accounting_append_next }}">
{% include "accounting/report/include/ledger-row-desktop.html" %} {% include "accounting/report/include/ledger-row-desktop.html" %}
</a> </a>
{% endfor %} {% endfor %}
@ -107,7 +107,7 @@ First written: 2023/3/5
{% endwith %} {% endwith %}
{% endif %} {% endif %}
{% for entry in report.entries %} {% for entry in report.entries %}
<a class="list-group-item list-group-item-action d-flex justify-content-between" href="{{ url_for("accounting.transaction.detail", txn=entry.transaction)|accounting_append_next }}"> <a class="list-group-item list-group-item-action d-flex justify-content-between" href="{{ entry.url|accounting_append_next }}">
{% include "accounting/report/include/ledger-row-mobile.html" %} {% include "accounting/report/include/ledger-row-mobile.html" %}
</a> </a>
{% endfor %} {% endfor %}