From 6fc21f82afd62ca0eef30a5a68ed80d3ba6be0e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=BE=9D=E7=91=AA=E8=B2=93?= <imacat@mail.imacat.idv.tw>
Date: Thu, 9 Mar 2023 07:30:04 +0800
Subject: [PATCH] Changed the entry parameter of the ReportEntry class in
 journal to be non-optional.  There is no optional entry in its actual use.

---
 src/accounting/report/reports/journal.py | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/src/accounting/report/reports/journal.py b/src/accounting/report/reports/journal.py
index f7cc658..7b573e2 100644
--- a/src/accounting/report/reports/journal.py
+++ b/src/accounting/report/reports/journal.py
@@ -40,12 +40,12 @@ from .utils.report_type import ReportType
 class ReportEntry:
     """An entry in the report."""
 
-    def __init__(self, entry: JournalEntry | None = None):
+    def __init__(self, entry: JournalEntry):
         """Constructs the entry in the report.
 
         :param entry: The journal entry.
         """
-        self.entry: JournalEntry | None = None
+        self.entry: JournalEntry = entry
         """The journal entry."""
         self.transaction: Transaction | None = None
         """The transaction."""
@@ -53,23 +53,16 @@ class ReportEntry:
         """Whether this is the total entry."""
         self.currency: Currency | None = None
         """The account."""
-        self.account: Account | None = None
+        self.account: Account = entry.account
         """The account."""
-        self.summary: str | None = None
+        self.summary: str | None = entry.summary
         """The summary."""
-        self.debit: Decimal | None = None
+        self.debit: Decimal | None = entry.amount if entry.is_debit else None
         """The debit amount."""
-        self.credit: Decimal | None = None
+        self.credit: Decimal | None = None if entry.is_debit else entry.amount
         """The credit amount."""
-        self.amount: Decimal | None = None
+        self.amount: Decimal = entry.amount
         """The amount."""
-        if entry is not None:
-            self.entry = entry
-            self.account = entry.account
-            self.summary = entry.summary
-            self.debit = entry.amount if entry.is_debit else None
-            self.credit = None if entry.is_debit else entry.amount
-            self.amount = entry.amount
 
 
 class CSVRow(BaseCSVRow):