Renamed all the is_XXX_needed properties to is_need_XXX. For example, especially the is_offset_needed property to is_need_offset, to be clear and understandable.

src/accounting/account/commands.py

@@ -29,7 +29,7 @@ from accounting.utils.user import has_user, get_user_pk
 
 AccountData = tuple[int, str, int, str, str, str, bool]
 """The format of the account data, as a list of (ID, base account code, number,
-English, Traditional Chinese, Simplified Chinese, is-offset-needed) tuples."""
+English, Traditional Chinese, Simplified Chinese, is-need-offset) tuples."""
 
 
 def __validate_username(ctx: click.core.Context, param: click.core.Option,
@@ -92,14 +92,14 @@ def init_accounts_command(username: str) -> None:
     data: list[AccountData] = []
     for base in bases_to_add:
         l10n: dict[str, str] = {x.locale: x.title for x in base.l10n}
-        is_offset_needed: bool = __is_offset_needed(base.code)
+        is_need_offset: bool = __is_need_offset(base.code)
         data.append((get_new_id(), base.code, 1, base.title_l10n,
-                     l10n["zh_Hant"], l10n["zh_Hans"], is_offset_needed))
+                     l10n["zh_Hant"], l10n["zh_Hans"], is_need_offset))
     __add_accounting_accounts(data, creator_pk)
     click.echo(F"{len(data)} added.  Accounting accounts initialized.")
 
 
-def __is_offset_needed(base_code: str) -> bool:
+def __is_need_offset(base_code: str) -> bool:
     """Checks that whether entries in the account need offset.
 
     :param base_code: The code of the base account.
@@ -134,7 +134,7 @@ def __add_accounting_accounts(data: list[AccountData], creator_pk: int)\
                                        base_code=x[1],
                                        no=x[2],
                                        title_l10n=x[3],
-                                       is_offset_needed=x[6],
+                                       is_need_offset=x[6],
                                        created_by_id=creator_pk,
                                        updated_by_id=creator_pk)
                                for x in data]

src/accounting/account/forms.py

@@ -80,7 +80,7 @@ class AccountForm(FlaskForm):
         filters=[strip_text],
         validators=[DataRequired(lazy_gettext("Please fill in the title"))])
     """The title."""
-    is_offset_needed = BooleanField(
+    is_need_offset = BooleanField(
         validators=[NoOffsetNominalAccount()])
     """Whether the the entries of this account need offset."""
 
@@ -103,9 +103,9 @@ class AccountForm(FlaskForm):
             obj.no = count + 1
         obj.title = self.title.data
         if self.base_code.data[0] in {"1", "2", "3"}:
-            obj.is_offset_needed = self.is_offset_needed.data
+            obj.is_need_offset = self.is_need_offset.data
         else:
-            obj.is_offset_needed = False
+            obj.is_need_offset = False
         if is_new:
             current_user_pk: int = get_current_user_pk()
             obj.created_by_id = current_user_pk

src/accounting/account/queries.py

@@ -48,7 +48,7 @@ def get_account_query() -> list[Account]:
                code.contains(k),
                Account.id.in_(l10n_matches)]
         if k in gettext("Need offset"):
-            sub_conditions.append(Account.is_offset_needed)
+            sub_conditions.append(Account.is_need_offset)
         conditions.append(sa.or_(*sub_conditions))
 
     return Account.query.filter(*conditions)\