imacat/mia-accounting
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 41 Wiki Activity

Renamed the variables for the button elements in the summary helper, to be clear.

Browse Source
This commit is contained in:
依瑪貓 2023-02-28 22:37:46 +08:00
parent 3c413497ae
commit 35b3bca1e6
1 changed files with 114 additions and 114 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

228
src/accounting/static/js/summary-helper.js
View File

@ -110,9 +110,9 @@ class SummaryHelper {
} }
} }
let selectedBtnTag = null; let selectedBtnTag = null;
for (const btnTag of tagButtons) { for (const tagButton of tagButtons) {
if (btnTag.classList.contains("btn-primary")) { if (tagButton.classList.contains("btn-primary")) {
selectedBtnTag = btnTag; selectedBtnTag = tagButton;
break; break;
} }
} }
@ -124,7 +124,7 @@ class SummaryHelper {
* *
*/ */
#initializeGeneralTagHelper() { #initializeGeneralTagHelper() {
const buttons = Array.from(document.getElementsByClassName(this.#prefix + "-general-btn-tag")); const tagButtons = Array.from(document.getElementsByClassName(this.#prefix + "-general-btn-tag"));
const summary = document.getElementById(this.#prefix + "-summary"); const summary = document.getElementById(this.#prefix + "-summary");
const tag = document.getElementById(this.#prefix + "-general-tag"); const tag = document.getElementById(this.#prefix + "-general-tag");
const helper = this; const helper = this;
@ -137,30 +137,30 @@ class SummaryHelper {
summary.value = prefix + summary.value.substring(pos + 1); summary.value = prefix + summary.value.substring(pos + 1);
} }
} }
for (const button of buttons) { for (const tagButton of tagButtons) {
button.onclick = function () { tagButton.onclick = function () {
for (const otherButton of buttons) { for (const otherButton of tagButtons) {
otherButton.classList.remove("btn-primary"); otherButton.classList.remove("btn-primary");
otherButton.classList.add("btn-outline-primary"); otherButton.classList.add("btn-outline-primary");
} }
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
tag.value = button.dataset.value; tag.value = tagButton.dataset.value;
helper.#filterSuggestedAccounts(button); helper.#filterSuggestedAccounts(tagButton);
updateSummary(); updateSummary();
}; };
} }
tag.onchange = function () { tag.onchange = function () {
let isMatched = false; let isMatched = false;
for (const button of buttons) { for (const tagButton of tagButtons) {
if (button.dataset.value === tag.value) { if (tagButton.dataset.value === tag.value) {
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
helper.#filterSuggestedAccounts(button); helper.#filterSuggestedAccounts(tagButton);
isMatched = true; isMatched = true;
} else { } else {
button.classList.remove("btn-primary"); tagButton.classList.remove("btn-primary");
button.classList.add("btn-outline-primary"); tagButton.classList.add("btn-outline-primary");
} }
} }
if (!isMatched) { if (!isMatched) {
@ -175,7 +175,7 @@ class SummaryHelper {
* *
*/ */
#initializeGeneralTripHelper() { #initializeGeneralTripHelper() {
const buttons = Array.from(document.getElementsByClassName(this.#prefix + "-travel-btn-tag")); const tagButtons = Array.from(document.getElementsByClassName(this.#prefix + "-travel-btn-tag"));
const summary = document.getElementById(this.#prefix + "-summary"); const summary = document.getElementById(this.#prefix + "-summary");
const tag = document.getElementById(this.#prefix + "-travel-tag"); const tag = document.getElementById(this.#prefix + "-travel-tag");
const from = document.getElementById(this.#prefix + "-travel-from"); const from = document.getElementById(this.#prefix + "-travel-from");
@ -184,38 +184,38 @@ class SummaryHelper {
const helper = this; const helper = this;
const updateSummary = function () { const updateSummary = function () {
let direction; let direction;
for (const button of directionButtons) { for (const directionButton of directionButtons) {
if (button.classList.contains("btn-primary")) { if (directionButton.classList.contains("btn-primary")) {
direction = button.dataset.arrow; direction = directionButton.dataset.arrow;
break; break;
} }
} }
summary.value = tag.value + "—" + from.value + direction + to.value; summary.value = tag.value + "—" + from.value + direction + to.value;
}; };
for (const button of buttons) { for (const tagButton of tagButtons) {
button.onclick = function () { tagButton.onclick = function () {
for (const otherButton of buttons) { for (const otherButton of tagButtons) {
otherButton.classList.remove("btn-primary"); otherButton.classList.remove("btn-primary");
otherButton.classList.add("btn-outline-primary"); otherButton.classList.add("btn-outline-primary");
} }
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
tag.value = button.dataset.value; tag.value = tagButton.dataset.value;
helper.#filterSuggestedAccounts(button); helper.#filterSuggestedAccounts(tagButton);
updateSummary(); updateSummary();
}; };
} }
tag.onchange = function () { tag.onchange = function () {
let isMatched = false; let isMatched = false;
for (const button of buttons) { for (const tagButton of tagButtons) {
if (button.dataset.value === tag.value) { if (tagButton.dataset.value === tag.value) {
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
helper.#filterSuggestedAccounts(button); helper.#filterSuggestedAccounts(tagButton);
isMatched = true; isMatched = true;
} else { } else {
button.classList.remove("btn-primary"); tagButton.classList.remove("btn-primary");
button.classList.add("btn-outline-primary"); tagButton.classList.add("btn-outline-primary");
} }
} }
if (!isMatched) { if (!isMatched) {
@ -228,14 +228,14 @@ class SummaryHelper {
updateSummary(); updateSummary();
helper.#validateGeneralTripFrom(); helper.#validateGeneralTripFrom();
}; };
for (const button of directionButtons) { for (const directionButton of directionButtons) {
button.onclick = function () { directionButton.onclick = function () {
for (const otherButton of directionButtons) { for (const otherButton of directionButtons) {
otherButton.classList.remove("btn-primary"); otherButton.classList.remove("btn-primary");
otherButton.classList.add("btn-outline-primary"); otherButton.classList.add("btn-outline-primary");
} }
button.classList.remove("btn-outline-primary"); directionButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); directionButton.classList.add("btn-primary");
updateSummary(); updateSummary();
}; };
} }
@ -250,7 +250,7 @@ class SummaryHelper {
* *
*/ */
#initializeBusTripHelper() { #initializeBusTripHelper() {
const buttons = Array.from(document.getElementsByClassName(this.#prefix + "-bus-btn-tag")); const tagButtons = Array.from(document.getElementsByClassName(this.#prefix + "-bus-btn-tag"));
const summary = document.getElementById(this.#prefix + "-summary"); const summary = document.getElementById(this.#prefix + "-summary");
const tag = document.getElementById(this.#prefix + "-bus-tag"); const tag = document.getElementById(this.#prefix + "-bus-tag");
const route = document.getElementById(this.#prefix + "-bus-route"); const route = document.getElementById(this.#prefix + "-bus-route");
@ -260,30 +260,30 @@ class SummaryHelper {
const updateSummary = function () { const updateSummary = function () {
summary.value = tag.value + "—" + route.value + "—" + from.value + "→" + to.value; summary.value = tag.value + "—" + route.value + "—" + from.value + "→" + to.value;
}; };
for (const button of buttons) { for (const tagButton of tagButtons) {
button.onclick = function () { tagButton.onclick = function () {
for (const otherButton of buttons) { for (const otherButton of tagButtons) {
otherButton.classList.remove("btn-primary"); otherButton.classList.remove("btn-primary");
otherButton.classList.add("btn-outline-primary"); otherButton.classList.add("btn-outline-primary");
} }
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
tag.value = button.dataset.value; tag.value = tagButton.dataset.value;
helper.#filterSuggestedAccounts(button); helper.#filterSuggestedAccounts(tagButton);
updateSummary(); updateSummary();
}; };
} }
tag.onchange = function () { tag.onchange = function () {
let isMatched = false; let isMatched = false;
for (const button of buttons) { for (const tagButton of tagButtons) {
if (button.dataset.value === tag.value) { if (tagButton.dataset.value === tag.value) {
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
helper.#filterSuggestedAccounts(button); helper.#filterSuggestedAccounts(tagButton);
isMatched = true; isMatched = true;
} else { } else {
button.classList.remove("btn-primary"); tagButton.classList.remove("btn-primary");
button.classList.add("btn-outline-primary"); tagButton.classList.add("btn-outline-primary");
} }
} }
if (!isMatched) { if (!isMatched) {
@ -309,25 +309,25 @@ class SummaryHelper {
/** /**
* Filters the suggested accounts. * Filters the suggested accounts.
* *
* @param btnTag {HTMLButtonElement|null} the tag button * @param tagButton {HTMLButtonElement|null} the tag button
*/ */
#filterSuggestedAccounts(btnTag) { #filterSuggestedAccounts(tagButton) {
const accountButtons = Array.from(document.getElementsByClassName(this.#prefix + "-account")); const accountButtons = Array.from(document.getElementsByClassName(this.#prefix + "-account"));
if (btnTag === null) { if (tagButton === null) {
for (const btnAccount of accountButtons) { for (const accountButton of accountButtons) {
btnAccount.classList.add("d-none"); accountButton.classList.add("d-none");
btnAccount.classList.remove("btn-primary"); accountButton.classList.remove("btn-primary");
btnAccount.classList.add("btn-outline-primary"); accountButton.classList.add("btn-outline-primary");
this.#selectAccount(null); this.#selectAccount(null);
} }
return; return;
} }
const suggested = JSON.parse(btnTag.dataset.accounts); const suggested = JSON.parse(tagButton.dataset.accounts);
for (const btnAccount of accountButtons) { for (const accountButton of accountButtons) {
if (suggested.includes(btnAccount.dataset.code)) { if (suggested.includes(accountButton.dataset.code)) {
btnAccount.classList.remove("d-none"); accountButton.classList.remove("d-none");
} else { } else {
btnAccount.classList.add("d-none"); accountButton.classList.add("d-none");
} }
this.#selectAccount(suggested[0]); this.#selectAccount(suggested[0]);
} }
@ -358,9 +358,9 @@ class SummaryHelper {
#initializeSuggestedAccounts() { #initializeSuggestedAccounts() {
const accountButtons = Array.from(document.getElementsByClassName(this.#prefix + "-account")); const accountButtons = Array.from(document.getElementsByClassName(this.#prefix + "-account"));
const helper = this; const helper = this;
for (const btnAccount of accountButtons) { for (const accountButton of accountButtons) {
btnAccount.onclick = function () { accountButton.onclick = function () {
helper.#selectAccount(btnAccount.dataset.code); helper.#selectAccount(accountButton.dataset.code);
}; };
} }
} }
@ -378,15 +378,15 @@ class SummaryHelper {
return; return;
} }
const accountButtons = Array.from(document.getElementsByClassName(this.#prefix + "-account")); const accountButtons = Array.from(document.getElementsByClassName(this.#prefix + "-account"));
for (const btnAccount of accountButtons) { for (const accountButton of accountButtons) {
if (btnAccount.dataset.code === selectedCode) { if (accountButton.dataset.code === selectedCode) {
btnAccount.classList.remove("btn-outline-primary"); accountButton.classList.remove("btn-outline-primary");
btnAccount.classList.add("btn-primary"); accountButton.classList.add("btn-primary");
form.dataset.selectedAccountCode = btnAccount.dataset.code; form.dataset.selectedAccountCode = accountButton.dataset.code;
form.dataset.selectedAccountText = btnAccount.dataset.text; form.dataset.selectedAccountText = accountButton.dataset.text;
} else { } else {
btnAccount.classList.remove("btn-primary"); accountButton.classList.remove("btn-primary");
btnAccount.classList.add("btn-outline-primary"); accountButton.classList.add("btn-outline-primary");
} }
} }
} }
@ -643,11 +643,11 @@ class SummaryHelper {
*/ */
initShow(isNew) { initShow(isNew) {
const closeButtons = Array.from(document.getElementsByClassName(this.#prefix + "-close")); const closeButtons = Array.from(document.getElementsByClassName(this.#prefix + "-close"));
for (const button of closeButtons) { for (const closeButton of closeButtons) {
if (isNew) { if (isNew) {
button.dataset.bsTarget = "#" + this.#prefix + "-modal"; closeButton.dataset.bsTarget = "#" + this.#prefix + "-modal";
} else { } else {
button.dataset.bsTarget = "#accounting-entry-form-modal"; closeButton.dataset.bsTarget = "#accounting-entry-form-modal";
} }
} }
this.#reset(); this.#reset();
@ -668,17 +668,17 @@ class SummaryHelper {
input.value = ""; input.value = "";
input.classList.remove("is-invalid"); input.classList.remove("is-invalid");
} }
for (const button of tagButtons) { for (const tagButton of tagButtons) {
button.classList.remove("btn-primary"); tagButton.classList.remove("btn-primary");
button.classList.add("btn-outline-primary"); tagButton.classList.add("btn-outline-primary");
} }
for (const button of directionButtons) { for (const directionButton of directionButtons) {
if (button.classList.contains("accounting-default")) { if (directionButton.classList.contains("accounting-default")) {
button.classList.remove("btn-outline-primary"); directionButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); directionButton.classList.add("btn-primary");
} else { } else {
button.classList.add("btn-outline-primary"); directionButton.classList.add("btn-outline-primary");
button.classList.remove("btn-primary"); directionButton.classList.remove("btn-primary");
} }
} }
this.#filterSuggestedAccounts(null); this.#filterSuggestedAccounts(null);
@ -727,7 +727,7 @@ class SummaryHelper {
const from = document.getElementById(this.#prefix + "-bus-from"); const from = document.getElementById(this.#prefix + "-bus-from");
const to = document.getElementById(this.#prefix + "-bus-to"); const to = document.getElementById(this.#prefix + "-bus-to");
const number = document.getElementById(this.#prefix + "-number"); const number = document.getElementById(this.#prefix + "-number");
const buttons = Array.from(document.getElementsByClassName(this.#prefix + "-bus-btn-tag")); const tagButtons = Array.from(document.getElementsByClassName(this.#prefix + "-bus-btn-tag"));
tag.value = tagName; tag.value = tagName;
route.value = routeName; route.value = routeName;
from.value = fromName; from.value = fromName;
@ -735,11 +735,11 @@ class SummaryHelper {
if (numberStr !== undefined) { if (numberStr !== undefined) {
number.value = parseInt(numberStr); number.value = parseInt(numberStr);
} }
for (const button of buttons) { for (const tagButton of tagButtons) {
if (button.dataset.value === tagName) { if (tagButton.dataset.value === tagName) {
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
this.#filterSuggestedAccounts(button); this.#filterSuggestedAccounts(tagButton);
} }
} }
this.#switchToTab("bus"); this.#switchToTab("bus");
@ -759,28 +759,28 @@ class SummaryHelper {
const from = document.getElementById(this.#prefix + "-travel-from"); const from = document.getElementById(this.#prefix + "-travel-from");
const to = document.getElementById(this.#prefix + "-travel-to"); const to = document.getElementById(this.#prefix + "-travel-to");
const number = document.getElementById(this.#prefix + "-number"); const number = document.getElementById(this.#prefix + "-number");
const buttons = Array.from(document.getElementsByClassName(this.#prefix + "-travel-btn-tag")); const tagButtons = Array.from(document.getElementsByClassName(this.#prefix + "-travel-btn-tag"));
const directionButtons = Array.from(document.getElementsByClassName(this.#prefix + "-travel-direction")); const directionButtons = Array.from(document.getElementsByClassName(this.#prefix + "-travel-direction"));
tag.value = tagName; tag.value = tagName;
from.value = fromName; from.value = fromName;
for (const btnDirection of directionButtons) { for (const directionButton of directionButtons) {
if (btnDirection.dataset.arrow === direction) { if (directionButton.dataset.arrow === direction) {
btnDirection.classList.remove("btn-outline-primary"); directionButton.classList.remove("btn-outline-primary");
btnDirection.classList.add("btn-primary"); directionButton.classList.add("btn-primary");
} else { } else {
btnDirection.classList.add("btn-outline-primary"); directionButton.classList.add("btn-outline-primary");
btnDirection.classList.remove("btn-primary"); directionButton.classList.remove("btn-primary");
} }
} }
to.value = toName; to.value = toName;
if (numberStr !== undefined) { if (numberStr !== undefined) {
number.value = parseInt(numberStr); number.value = parseInt(numberStr);
} }
for (const button of buttons) { for (const tagButton of tagButtons) {
if (button.dataset.value === tagName) { if (tagButton.dataset.value === tagName) {
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
this.#filterSuggestedAccounts(button); this.#filterSuggestedAccounts(tagButton);
} }
} }
this.#switchToTab("travel"); this.#switchToTab("travel");
@ -795,16 +795,16 @@ class SummaryHelper {
#populateGeneralTag(tagName, numberStr) { #populateGeneralTag(tagName, numberStr) {
const tag = document.getElementById(this.#prefix + "-general-tag"); const tag = document.getElementById(this.#prefix + "-general-tag");
const number = document.getElementById(this.#prefix + "-number"); const number = document.getElementById(this.#prefix + "-number");
const buttons = Array.from(document.getElementsByClassName(this.#prefix + "-general-btn-tag")); const tagButtons = Array.from(document.getElementsByClassName(this.#prefix + "-general-btn-tag"));
tag.value = tagName; tag.value = tagName;
if (numberStr !== undefined) { if (numberStr !== undefined) {
number.value = parseInt(numberStr); number.value = parseInt(numberStr);
} }
for (const button of buttons) { for (const tagButton of tagButtons) {
if (button.dataset.value === tagName) { if (tagButton.dataset.value === tagName) {
button.classList.remove("btn-outline-primary"); tagButton.classList.remove("btn-outline-primary");
button.classList.add("btn-primary"); tagButton.classList.add("btn-primary");
this.#filterSuggestedAccounts(button); this.#filterSuggestedAccounts(tagButton);
} }
} }
this.#switchToTab("general"); this.#switchToTab("general");