From 220dbaa683ade8ae73b4d233ceca153a02818033 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=BE=9D=E7=91=AA=E8=B2=93?= <imacat@mail.imacat.idv.tw>
Date: Wed, 15 Apr 2026 22:37:49 +0800
Subject: [PATCH] Convert navbar dropdown span to button for accessibility

---
 src/accounting/templates/accounting/include/nav.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/accounting/templates/accounting/include/nav.html b/src/accounting/templates/accounting/include/nav.html
index 09c5f13..56949a8 100644
--- a/src/accounting/templates/accounting/include/nav.html
+++ b/src/accounting/templates/accounting/include/nav.html
@@ -22,10 +22,10 @@ First written: 2023/1/26
 {# <ul> For SonarQube not to complain about incorrect HTML #}
 {% if accounting_can_view() %}
   <li class="nav-item dropdown">
-    <span class="nav-link dropdown-toggle" data-bs-toggle="dropdown">
+    <button class="nav-link dropdown-toggle" type="button" data-bs-toggle="dropdown" aria-expanded="false">
       <i class="fa-solid fa-file-invoice-dollar" aria-hidden="true"></i>
       {{ A_("Accounting") }}
-    </span>
+    </button>
     <ul class="dropdown-menu">
       <li>
         <a class="dropdown-item {% if request.endpoint and request.endpoint.startswith("accounting-report.") %} active {% endif %}" href="{{ url_for("accounting-report.default") }}">