imacat/mia-accounting-django
1
0
Fork 0
Code Issues Pull Requests Projects Releases 4 Wiki Activity

Replaced the raw SQL query with the Django ORM query in the get_ledger_accounts() utility in the accounting application.

Browse Source
This commit is contained in:
依瑪貓 2020-08-12 23:48:29 +08:00
parent e736e51fd3
commit 4f74a501d6
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
accounting/utils.py
View File

@ -300,8 +300,9 @@ def get_ledger_accounts():
Returns: Returns:
list[Account]: The accounts for the ledger. list[Account]: The accounts for the ledger.
""" """
# TODO: Te be replaced with the Django model queries """
return list(Account.objects.raw("""SELECT s.* For SQL one-liner:
SELECT s.*
FROM accounting_accounts AS s FROM accounting_accounts AS s
WHERE s.code IN (SELECT s.code WHERE s.code IN (SELECT s.code
FROM accounting_accounts AS s FROM accounting_accounts AS s
@ -311,7 +312,15 @@ def get_ledger_accounts():
GROUP BY s.code) AS u GROUP BY s.code) AS u
ON u.code LIKE s.code || '%%' ON u.code LIKE s.code || '%%'
GROUP BY s.code) GROUP BY s.code)
ORDER BY s.code""")) ORDER BY s.code
"""
codes = {}
for code in [x.code for x in Account.objects
.annotate(Count("record")).filter(record__count__gt=0)]:
while len(code) > 0:
codes[code] = True
code = code[:-1]
return Account.objects.filter(code__in=codes).order_by("code")
def get_default_ledger_account(): def get_default_ledger_account():