Fix open redirect vulnerability in return-to URL after login

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-07 08:13:12 +08:00
parent ddab7b3fe9
commit eea79c852b
2 changed files with 29 additions and 1 deletions

View File

@@ -61,10 +61,15 @@ export const useLoginStore = defineStore('loginStore', {
// 則在此情況下時,我們會在使用者稍後登入後,把使用者帶到剛才記住的 return-to 網址
if(this.rememberedReturnToUrl !== "") {
const decodedUrl = atob(this.rememberedReturnToUrl);
// Only allow relative paths to prevent open redirect attacks
if(decodedUrl.startsWith('/') && !decodedUrl.startsWith('//')) {
window.location.href = decodedUrl;
} else {
this.$router.push('/files');
}
} else {
this.$router.push('/files');
}
} catch(error) {
this.isInvalid = true;
};

View File

@@ -107,6 +107,29 @@ describe('loginStore', () => {
window.location = originalLocation;
});
it('does not redirect to external URL (open redirect prevention)', async () => {
axios.post.mockResolvedValue({
data: {
access_token: 'token',
refresh_token: 'refresh',
},
});
// Attacker crafts a return-to URL pointing to an external site
store.rememberedReturnToUrl = btoa('https://evil.example.com/steal');
const originalLocation = window.location;
delete window.location;
window.location = { href: '' };
await store.signIn();
// Should NOT redirect to the external URL
expect(window.location.href).not.toBe('https://evil.example.com/steal');
// Should fall back to /files
expect(store.$router.push).toHaveBeenCalledWith('/files');
window.location = originalLocation;
});
it('sets isInvalid on error', async () => {
axios.post.mockRejectedValue(new Error('401'));