imacat/lucia-frontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace .map() with .forEach() where return value is unused

Browse Source 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
依瑪貓
2026-03-06 08:46:01 +08:00
parent 79811435de
commit dfd5706bcf
8 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/views/Compare/MapCompare.vue
View File

@@ -384,7 +384,7 @@
};
mapData.edges = [];
this[mapType].edges.map(edge => {
this[mapType].edges.forEach(edge => {
mapData.edges.push({
data: {
source:edge.tail,
@@ -426,7 +426,7 @@
// 找出 type activity's node
const activityNodeArray = nodes.filter(node => node.data.type === 'activity');
// 找出除了 start, end 以外所有的 node 的 option value
activityNodeArray.map(node => nodeOptionArr.push(node.data[this.dataLayerType][this.dataLayerOption]));
activityNodeArray.forEach(node => nodeOptionArr.push(node.data[this.dataLayerType][this.dataLayerOption]));
// 將node的option值從小到大排序(映對色階淺到深)
nodeOptionArr = nodeOptionArr.sort((a, b) => a - b);
for(let i = 0; i < ImgCapsules.length; i++) {
@@ -435,10 +435,10 @@
leveledGroups.push(nodeOptionArr.slice(startIdx, endIdx));
}
for(let level = 0; level < leveledGroups.length; level++) {
leveledGroups[level].map(option => {
leveledGroups[level].forEach(option => {
// 考慮可能有名次一樣的情形
const curNodes = activityNodeArray.filter(activityNode => activityNode.data[this.dataLayerType][this.dataLayerOption] === option);
curNodes.map(curNode => {
curNodes.forEach(curNode => {
curNode.data = {
...curNode.data,
nodeImageUrl: ImgCapsules[level],

8
src/views/Discover/Map/Map.vue
View File

@@ -401,7 +401,7 @@ export default {
};
mapData.edges = [];
this[mapType].edges.map(edge => {
this[mapType].edges.forEach(edge => {
mapData.edges.push({
data: {
source: edge.tail,
@@ -444,7 +444,7 @@ export default {
// 找出 type activity's node
const activityNodeArray = nodes.filter(node => node.data.type === 'activity');
// 找出除了 start, end 以外所有的 node 的 option value
activityNodeArray.map(node => nodeOptionArr.push(node.data[this.dataLayerType][this.dataLayerOption]));
activityNodeArray.forEach(node => nodeOptionArr.push(node.data[this.dataLayerType][this.dataLayerOption]));
// 將node的option值從小到大排序(映對色階淺到深)
nodeOptionArr = nodeOptionArr.sort((a, b) => a - b);
for (let i = 0; i < ImgCapsules.length; i++) {
@@ -453,10 +453,10 @@ export default {
leveledGroups.push(nodeOptionArr.slice(startIdx, endIdx));
}
for (let level = 0; level < leveledGroups.length; level++) {
leveledGroups[level].map(option => {
leveledGroups[level].forEach(option => {
// 考慮可能有名次一樣的情形
const curNodes = activityNodeArray.filter(activityNode => activityNode.data[this.dataLayerType][this.dataLayerOption] === option);
curNodes.map(curNode => {
curNodes.forEach(curNode => {
curNode.data = {
...curNode.data,
nodeImageUrl: ImgCapsules[level],