From c88646eba31996fc3e534a9259b604fb46e1dcc9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=BE=9D=E7=91=AA=E8=B2=93?= <imacat@mail.imacat.idv.tw>
Date: Sun, 8 Mar 2026 12:39:11 +0800
Subject: [PATCH] Enable vue/return-in-computed-property and add explicit
 fallback returns

Co-Authored-By: Codex <codex@openai.com>
---
 eslint.config.mjs                                 | 2 +-
 src/components/Discover/Conformance/MoreModal.vue | 1 +
 src/components/Discover/Map/Filter/Attributes.vue | 3 ++-
 src/components/Navbar.vue                         | 2 ++
 src/views/Files/Files.vue                         | 1 +
 5 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/eslint.config.mjs b/eslint.config.mjs
index 294e489..4439c0c 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -118,7 +118,7 @@ export default [
     rules: {
       "vue/multi-word-component-names": "off",
       "vue/no-side-effects-in-computed-properties": "off",
-      "vue/return-in-computed-property": "off",
+      "vue/return-in-computed-property": "error",
       "vue/no-parsing-error": "error",
       "vue/valid-v-else": "error",
       "vue/no-deprecated-v-on-native-modifier": "error",
diff --git a/src/components/Discover/Conformance/MoreModal.vue b/src/components/Discover/Conformance/MoreModal.vue
index 446aa88..37c1f08 100644
--- a/src/components/Discover/Conformance/MoreModal.vue
+++ b/src/components/Discover/Conformance/MoreModal.vue
@@ -195,6 +195,7 @@ const caseData = computed(() => {
     });
     return data;
   }
+  return [];
 });
 
 const columnData = computed(() => {
diff --git a/src/components/Discover/Map/Filter/Attributes.vue b/src/components/Discover/Map/Filter/Attributes.vue
index 88c3792..f47ae26 100644
--- a/src/components/Discover/Map/Filter/Attributes.vue
+++ b/src/components/Discover/Map/Filter/Attributes.vue
@@ -428,8 +428,9 @@ const valueData = computed(() => {
         item.type === selectedAttName.value.type &&
         item.key === selectedAttName.value.key,
     );
-    return data;
+    return data ?? null;
   }
+  return null;
 });
 
 // Compute slider data; time format: millisecond timestamps
diff --git a/src/components/Navbar.vue b/src/components/Navbar.vue
index 20d7916..2cc6ae0 100644
--- a/src/components/Navbar.vue
+++ b/src/components/Navbar.vue
@@ -177,6 +177,8 @@ const disabledSave = computed(() => {
       return !(
         conformanceFilterTempCheckId.value || conformanceLogTempCheckId.value
       );
+    default:
+      return true;
   }
 });
 
diff --git a/src/views/Files/Files.vue b/src/views/Files/Files.vue
index a9e8aa0..8b4a52b 100644
--- a/src/views/Files/Files.vue
+++ b/src/views/Files/Files.vue
@@ -560,6 +560,7 @@ const allFiles = computed(() => {
     );
     return sortFiles;
   }
+  return [];
 });
 
 /**