From 75adbd9c6b4f9b5abb0592d240a33a6110c5f612 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=BE=9D=E7=91=AA=E8=B2=93?= Date: Tue, 10 Mar 2026 07:37:46 +0800 Subject: [PATCH] Use Math.min to simplify ternary clamping expressions (S7766) Co-Authored-By: Claude Opus 4.6 --- .../Discover/Map/Filter/AttributesFilter.vue | 24 +++++-------------- .../Discover/Map/Filter/TimeframesFilter.vue | 2 +- 2 files changed, 7 insertions(+), 19 deletions(-) diff --git a/src/components/Discover/Map/Filter/AttributesFilter.vue b/src/components/Discover/Map/Filter/AttributesFilter.vue index ad8eee0..d2c00da 100644 --- a/src/components/Discover/Map/Filter/AttributesFilter.vue +++ b/src/components/Discover/Map/Filter/AttributesFilter.vue @@ -68,7 +68,7 @@ dataKey="id" breakpoint="0" :tableClass="tableClass" - @row-select="onRowSelect" + @row-select="onRowSelectionChange" > @@ -140,8 +140,8 @@ dataKey="id" breakpoint="0" tableClass="w-full !border-separate !border-spacing-x-2 !table-auto text-sm" - @row-select="onRowSelect" - @row-unselect="onRowUnselect" + @row-select="onRowSelectionChange" + @row-unselect="onRowSelectionChange" @row-select-all="onRowSelectAll($event)" @row-unselect-all="onRowUnelectAll" > @@ -526,21 +526,9 @@ const labelsData = computed(() => { }); /** - * Selects an option in the categorical table. + * Emits the current attribute selection when a row is selected or deselected. */ -function onRowSelect() { - const type = selectedAttName.value.type; - const data = { - type: type, - data: selectedAttRange.value, - }; - emit("select-attribute", data); -} - -/** - * Deselects an option in the categorical table. - */ -function onRowUnselect() { +function onRowSelectionChange() { const type = selectedAttName.value.type; const data = { type: type, @@ -915,7 +903,7 @@ function sliderValueRange(e, direction) { (sliderData[sliderData.length - 1] - sliderData[0])) * sliderData.length; let result = Math.round(Math.abs(closestIndex)); - result = result > selectRange.value ? selectRange.value : result; + result = Math.min(result, selectRange.value); return result; }); // Update the slider diff --git a/src/components/Discover/Map/Filter/TimeframesFilter.vue b/src/components/Discover/Map/Filter/TimeframesFilter.vue index 399bc5c..5ae79c7 100644 --- a/src/components/Discover/Map/Filter/TimeframesFilter.vue +++ b/src/components/Discover/Map/Filter/TimeframesFilter.vue @@ -381,7 +381,7 @@ function sliderTimeRange(e, direction) { (sliderDataVal[sliderDataVal.length - 1] - sliderDataVal[0])) * sliderDataVal.length; let result = Math.round(Math.abs(closestIndex)); - result = result > selectRange.value ? selectRange.value : result; + result = Math.min(result, selectRange.value); return result; });