From 6a689e419c7990e9681250f22c358e880e4ec3c2 Mon Sep 17 00:00:00 2001
From: Cindy Chang <cindy.chang@dsp.im>
Date: Tue, 16 Jul 2024 15:18:31 +0800
Subject: [PATCH] sonar qube; getCookie refactored

---
 src/utils/cookieUtil.js                       | 21 +++++++++----------
 .../AccountAdmin/AccountAdmin.vue             |  4 ----
 .../AccountManagement/ModalAccountInfo.vue    |  2 --
 3 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/src/utils/cookieUtil.js b/src/utils/cookieUtil.js
index 5be2e8b..e768f76 100644
--- a/src/utils/cookieUtil.js
+++ b/src/utils/cookieUtil.js
@@ -1,18 +1,17 @@
 export function getCookie(name) {
-    const nameEqual = name + "=";
-    const cookieArr = document.cookie.split(';');
-    for (let i = 0; i < cookieArr.length; i++) {
-      let c = cookieArr[i];
-      while (c.charAt(0) === ' ') {
-        c = c.substring(1, c.length);
+  const nameEqual = name + "=";
+  const cookieArr = document.cookie.split(';');
+  
+  for (const cookie of cookieArr) {
+    let c = cookie.trim();
+    if (c.indexOf(nameEqual) === 0) {
+      return c.substring(nameEqual.length, c.length);
     }
-      if (c.indexOf(nameEqual) === 0) {
-        return c.substring(nameEqual.length, c.length);
-    }
-    }
-    return null;
   }
   
+  return null;
+}
+  
 export function setCookie(name, value, days=1) {
   let expires = "";
   if (days) {
diff --git a/src/views/AccountManagement/AccountAdmin/AccountAdmin.vue b/src/views/AccountManagement/AccountAdmin/AccountAdmin.vue
index 7e01c55..cd0d607 100644
--- a/src/views/AccountManagement/AccountAdmin/AccountAdmin.vue
+++ b/src/views/AccountManagement/AccountAdmin/AccountAdmin.vue
@@ -426,7 +426,6 @@ export default {
             this.isLoading = true;
             this.infiniteFinish = false;
                this.infiniteStart += ONCE_RENDER_NUM_OF_DATA;
-            // await this.acctMgmtStore.getAccountDetail();
             this.infiniteAcctDataVue2 = await [...this.infiniteAcctDataVue2, ...this.allUserAccoutList.slice(
                 this.infiniteStart, this.infiniteStart + ONCE_RENDER_NUM_OF_DATA)];
             this.isInfiniteFinish = true;
@@ -452,9 +451,6 @@ export default {
     },
     created() {
     },
-    mounted() {
-        this.isLoading = false; //TODO:
-    },
 };
 </script>
 <style>
diff --git a/src/views/AccountManagement/ModalAccountInfo.vue b/src/views/AccountManagement/ModalAccountInfo.vue
index df63bfb..34a272f 100644
--- a/src/views/AccountManagement/ModalAccountInfo.vue
+++ b/src/views/AccountManagement/ModalAccountInfo.vue
@@ -42,8 +42,6 @@ export default {
             name,
             is_admin,
             is_active,
-            is_sso,
-            has_data,
         } = currentViewingUser.value;
 
         onBeforeMount(async() => {