From 64372c7043919b0cd2191d09d560dffa2641913a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=BE=9D=E7=91=AA=E8=B2=93?= Date: Fri, 6 Mar 2026 09:22:36 +0800 Subject: [PATCH] Replace loose equality (== null, != null) with strict equality Co-Authored-By: Claude Opus 4.6 --- .../Discover/Conformance/ConformanceResults.vue | 8 ++++---- .../ConformanceSidebar/TimeRangeDuration.vue | 4 ++-- src/components/Discover/Conformance/MoreModal.vue | 8 ++++---- src/components/Discover/Map/SidebarFilter.vue | 2 +- src/stores/allMapData.js | 12 ++++++------ src/stores/files.js | 2 +- src/views/Files/Files.vue | 2 +- src/views/Upload/index.vue | 2 +- 8 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/components/Discover/Conformance/ConformanceResults.vue b/src/components/Discover/Conformance/ConformanceResults.vue index f8e6ccf..a9294f4 100644 --- a/src/components/Discover/Conformance/ConformanceResults.vue +++ b/src/components/Discover/Conformance/ConformanceResults.vue @@ -91,7 +91,7 @@
-
+

Loop List

@@ -138,12 +138,12 @@
-
+

Non-conformance Issues

-
+

Time Trendinfo {{ data.timeTrend.not_conforming }} / {{ data.timeTrend.total }} @@ -284,7 +284,7 @@ export default { watch: { conformanceTempReportData: { handler: function(newValue) { - if(newValue?.rule && newValue.rule.min != null) { + if(newValue?.rule && newValue.rule.min !== null) { this.selectDurationTime = { min: newValue.rule.min, max: newValue.rule.max, diff --git a/src/components/Discover/Conformance/ConformanceSidebar/TimeRangeDuration.vue b/src/components/Discover/Conformance/ConformanceSidebar/TimeRangeDuration.vue index c5634db..e5eb3c2 100644 --- a/src/components/Discover/Conformance/ConformanceSidebar/TimeRangeDuration.vue +++ b/src/components/Discover/Conformance/ConformanceSidebar/TimeRangeDuration.vue @@ -40,12 +40,12 @@ export default { handler: function(newValue, oldValue) { this.durationMax = null this.durationMin = null - if(newValue == null) { + if(newValue === null) { this.timeData = { min: 0, max: 0 }; - }else if(newValue != null) { + }else if(newValue !== null) { this.timeData = { min: newValue.min, max: newValue.max diff --git a/src/components/Discover/Conformance/MoreModal.vue b/src/components/Discover/Conformance/MoreModal.vue index be6a7e9..b12204c 100644 --- a/src/components/Discover/Conformance/MoreModal.vue +++ b/src/components/Discover/Conformance/MoreModal.vue @@ -141,7 +141,7 @@ export default { if(newValue) this.createCy(); }, taskSeq: function(newValue){ - if (newValue != null) this.createCy(); + if (newValue !== null) this.createCy(); }, traceId: function(newValue) { // 當 traceId 屬性變化時更新 showTraceId @@ -199,7 +199,7 @@ export default { // 避免每次渲染都重複累加 this.processMap.nodes = []; // 將 api call 回來的資料帶進 node - if(this.taskSeq != null) { + if(this.taskSeq !== null) { this.taskSeq.forEach((node, index) => { this.processMap.nodes.push({ data: { @@ -220,7 +220,7 @@ export default { */ setEdgesData(){ this.processMap.edges = []; - if(this.taskSeq != null) { + if(this.taskSeq !== null) { this.taskSeq.forEach((edge, index) => { this.processMap.edges.push({ data: { @@ -244,7 +244,7 @@ export default { this.setNodesData(); this.setEdgesData(); - if(graphId != null) cytoscapeMapTrace(this.processMap.nodes, this.processMap.edges, graphId); + if(graphId !== null) cytoscapeMapTrace(this.processMap.nodes, this.processMap.edges, graphId); }); }, /** diff --git a/src/components/Discover/Map/SidebarFilter.vue b/src/components/Discover/Map/SidebarFilter.vue index 1f017e2..2eb6e08 100644 --- a/src/components/Discover/Map/SidebarFilter.vue +++ b/src/components/Discover/Map/SidebarFilter.vue @@ -543,7 +543,7 @@ export default { case 'int': case 'float': case 'date': - return !(this.selectAttribute?.key && this.selectAttribute?.min != null && this.selectAttribute?.max != null); + return !(this.selectAttribute?.key && this.selectAttribute?.min !== null && this.selectAttribute?.max !== null); default: return true; } diff --git a/src/stores/allMapData.js b/src/stores/allMapData.js index 063b49f..97211ec 100644 --- a/src/stores/allMapData.js +++ b/src/stores/allMapData.js @@ -131,8 +131,8 @@ export default defineStore('allMapDataStore', { let api = ''; // 先判斷暫存 再判斷 filter 最後 log - if(tempFilterId != null) api = `/api/temp-filters/${tempFilterId}/discover`; - else if(createFilterId!= null) api = `/api/filters/${createFilterId}/discover`; + if(tempFilterId !== null) api = `/api/temp-filters/${tempFilterId}/discover`; + else if(createFilterId!== null) api = `/api/filters/${createFilterId}/discover`; else api = `/api/logs/${logId}/discover`; try { @@ -157,8 +157,8 @@ export default defineStore('allMapDataStore', { let api = ''; // 先判斷暫存 再判斷 filter 最後 log - if(tempFilterId != null) api = `/api/temp-filters/${tempFilterId}/traces`; - else if(createFilterId!= null) api = `/api/filters/${createFilterId}/traces`; + if(tempFilterId !== null) api = `/api/temp-filters/${tempFilterId}/traces`; + else if(createFilterId!== null) api = `/api/filters/${createFilterId}/traces`; else api = `/api/logs/${logId}/traces`; try { @@ -185,8 +185,8 @@ export default defineStore('allMapDataStore', { let api = ''; // 先判斷暫存 再判斷 filter 最後 log - if(tempFilterId != null) api = `/api/temp-filters/${tempFilterId}/traces/${traceId}?start=${start}&page_size=20`; - else if(createFilterId!= null) api = `/api/filters/${createFilterId}/traces/${traceId}?start=${start}&page_size=20`; + if(tempFilterId !== null) api = `/api/temp-filters/${tempFilterId}/traces/${traceId}?start=${start}&page_size=20`; + else if(createFilterId!== null) api = `/api/filters/${createFilterId}/traces/${traceId}?start=${start}&page_size=20`; else api = `/api/logs/${logId}/traces/${traceId}?start=${start}&page_size=20`; try { diff --git a/src/stores/files.js b/src/stores/files.js index 8e1cf3a..a0e3341 100644 --- a/src/stores/files.js +++ b/src/stores/files.js @@ -255,7 +255,7 @@ export default defineStore('filesStore', { async deleteFile(type, id) { let api; - if(id == null || isNaN(id)) { + if(id === null || id === undefined || isNaN(id)) { console.error('Delete File API Error: invalid id'); return; }; diff --git a/src/views/Files/Files.vue b/src/views/Files/Files.vue index 379bf46..bf98870 100644 --- a/src/views/Files/Files.vue +++ b/src/views/Files/Files.vue @@ -357,7 +357,7 @@ }, allFiles: { handler(newValue) { - if(newValue != null) this.compareData = JSON.parse(JSON.stringify(newValue)); + if(newValue !== null) this.compareData = JSON.parse(JSON.stringify(newValue)); } }, reallyDeleteData: { diff --git a/src/views/Upload/index.vue b/src/views/Upload/index.vue index 9ae0763..5c9af85 100644 --- a/src/views/Upload/index.vue +++ b/src/views/Upload/index.vue @@ -320,7 +320,7 @@ export default { beforeRouteEnter(to, from, next){ // 要有 uploadID 才能進來 next(vm => { - if(vm.uploadId == null) { + if(vm.uploadId === null) { vm.$router.push({name: 'Files', replace: true}); vm.$toast.default('Please upload your file.', {position: 'bottom'}); }