From 4ba7961a5a53474674bdf1dda785c4f0ca8a9153 Mon Sep 17 00:00:00 2001
From: Cindy Chang <cindy.chang@dsp.im>
Date: Fri, 2 Aug 2024 13:24:15 +0800
Subject: [PATCH] sonar

---
 src/module/cytoscapeMap.js   |  2 +-
 src/module/numberLabel.js    |  2 +-
 src/module/setChartData.js   |  2 --
 src/module/sortNumEngZhtw.js |  8 ++++----
 src/stores/conformance.js    |  2 +-
 src/views/Files/Files.vue    | 13 +++++--------
 6 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/src/module/cytoscapeMap.js b/src/module/cytoscapeMap.js
index 8e882fb..e788106 100644
--- a/src/module/cytoscapeMap.js
+++ b/src/module/cytoscapeMap.js
@@ -222,7 +222,7 @@ export default function cytoscapeMap(mapData, dataLayerType, dataLayerOption, cu
   // creat tippy.js
   let tip;
   cy.on('mouseover', 'node', function(event) {
-      var node = event.target
+      const node = event.target;
       let ref = node.popperRef()
       let dummyDomEle = document.createElement('div');
       let content = document.createElement('div');
diff --git a/src/module/numberLabel.js b/src/module/numberLabel.js
index 22c6102..e4ccf46 100644
--- a/src/module/numberLabel.js
+++ b/src/module/numberLabel.js
@@ -5,7 +5,7 @@
  * @returns
  */
 export default function numberLabel(num) {
-  var parts = num.toString().split('.');
+  let parts = num.toString().split('.');
   parts[0] = parts[0].replace(/\B(?=(\d{3})+(?!\d))/g, ',');
   return parts.join('.');
 }
diff --git a/src/module/setChartData.js b/src/module/setChartData.js
index 90cccdc..76870b0 100644
--- a/src/module/setChartData.js
+++ b/src/module/setChartData.js
@@ -177,7 +177,6 @@ export function yTimeRange(data, yAmount, yMax) {
  * @returns {numver} x index
  */
 export function getXIndex(data, xValue) {
-  let closestElement = data[0]; // 假定第一个元素是最接近的
   let closestIndex = xValue; // 假定第一个元素的索引是 0
   let smallestDifference = Math.abs(xValue - data[0]); // 初始差值设为第一个元素与目标数的差值
 
@@ -185,7 +184,6 @@ export function getXIndex(data, xValue) {
     let difference = Math.abs(xValue - data[i]);
 
     if (difference <= smallestDifference) {
-      closestElement = data[i];
       closestIndex = i;
       smallestDifference = difference;
     }
diff --git a/src/module/sortNumEngZhtw.js b/src/module/sortNumEngZhtw.js
index 1b4dd4a..ea5b925 100644
--- a/src/module/sortNumEngZhtw.js
+++ b/src/module/sortNumEngZhtw.js
@@ -6,8 +6,8 @@
 export function sortNumEngZhtw(data) {
   return data.sort((a, b) => {
     // 檢查兩個值是否都是數字
-    var isANumber = !isNaN(parseFloat(a)) && isFinite(a);
-    var isBNumber = !isNaN(parseFloat(b)) && isFinite(b);
+    const isANumber = !isNaN(parseFloat(a)) && isFinite(a);
+    const isBNumber = !isNaN(parseFloat(b)) && isFinite(b);
 
     // 如果兩個值都是數字，直接比較大小
     if (isANumber && isBNumber) return parseFloat(a) - parseFloat(b);
@@ -28,8 +28,8 @@ export function sortNumEngZhtw(data) {
  */
 export function sortNumEngZhtwForFilter(a, b) {
   // 檢查兩個值是否都是數字
-  var isANumber = !isNaN(parseFloat(a)) && isFinite(a);
-  var isBNumber = !isNaN(parseFloat(b)) && isFinite(b);
+  const isANumber = !isNaN(parseFloat(a)) && isFinite(a);
+  const isBNumber = !isNaN(parseFloat(b)) && isFinite(b);
 
   // 如果兩個值都是數字，直接比較大小
   if (isANumber && isBNumber) return parseFloat(a) - parseFloat(b);
diff --git a/src/stores/conformance.js b/src/stores/conformance.js
index c81aea8..5b2d98c 100644
--- a/src/stores/conformance.js
+++ b/src/stores/conformance.js
@@ -128,7 +128,7 @@ export default defineStore('conformanceStore', {
               case 'dummy': //sonar-qube
               case 'duration-list':
                 fac.value = fac.value.map(v => v !== null ? abbreviateNumber(new Decimal(v.toFixed(2))) : null);
-                fac.value = (fac.value).map(v => v = v.trim()).join(', ');
+                fac.value = (fac.value).map(v => v.trim()).join(', ');
                 break;
               default:
                 break;
diff --git a/src/views/Files/Files.vue b/src/views/Files/Files.vue
index f5ffc7c..8429bd2 100644
--- a/src/views/Files/Files.vue
+++ b/src/views/Files/Files.vue
@@ -402,17 +402,14 @@
             this.$router.push({name: 'Map', params: params});
             break;
           case 'log-check':
-            fileId = file.id;
-            type = file.parent.type;
-            params = { type: type, fileId: fileId };
-            this.$router.push({name: 'CheckConformance', params: params});
-            break
           case 'filter-check':
             fileId = file.id;
             type = file.parent.type;
             params = { type: type, fileId: fileId };
             this.$router.push({name: 'CheckConformance', params: params});
             break;
+          default:
+            break;
         }
       },
       /**
@@ -486,10 +483,11 @@
             switch (i.type) {
               case 'log-check':
                 i.type = 'rule';
-                break;
               case 'filter-check':
                 i.type = 'rule';
                 break;
+              default:
+                break;
             }
             let content = `<li>[${i.type}] ${i.name}</li>`;
             srt += content;
@@ -508,9 +506,8 @@
           this.reallyDeldetData.forEach(file => {
             switch (file.type) {
               case 'log-check':
-                file.type = 'rule';
-                break;
               case 'filter-check':
+              default:
                 file.type = 'rule';
                 break;
             }