From 9616fb3ddc52aeb59483cdaa2c76ea22bb20183c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=BE=9D=E7=91=AA=E8=B2=93?= Date: Tue, 29 Nov 2022 21:52:19 +0800 Subject: [PATCH] Added the get_opaque inline function in the make_response_header method of the DigestAuth class for readability. --- src/flask_digest_auth/auth.py | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/flask_digest_auth/auth.py b/src/flask_digest_auth/auth.py index 927598d..a5c7858 100644 --- a/src/flask_digest_auth/auth.py +++ b/src/flask_digest_auth/auth.py @@ -203,9 +203,19 @@ class DigestAuth: :param state: The authorization state. :return: The WWW-Authenticate response header. """ - opaque: t.Optional[str] = None if not self.use_opaque else \ - (state.opaque if state.opaque is not None - else self.serializer.dumps(randbits(32), salt="opaque")) + + def get_opaque() -> t.Optional[str]: + """Returns the opaque value. + + :return: The opaque value. + """ + if not self.use_opaque: + return None + if state.opaque is not None: + return state.opaque + return self.serializer.dumps(randbits(32), salt="opaque") + + opaque: t.Optional[str] = get_opaque() nonce: str = self.serializer.dumps( randbits(32), salt="nonce" if opaque is None else f"nonce-{opaque}")